pgsql: Fix lcov duplicate directory specification in non-VPATH builds. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix lcov duplicate directory specification in non-VPATH builds.
Date
Msg-id E1xD4jG-00000000BKh-24dU@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix lcov duplicate directory specification in non-VPATH builds.

In an in-tree build, "make coverage-html" invoked lcov with two
"-d ." options, because $(srcdir) is just ".".  With lcov 2.0
(and perhaps earlier versions?) that results in scanning every
foo.gcda file twice and producing counts twice what they should
be.  With later lcov versions (at least 2.3), it results in
"duplicate file" errors.

In VPATH builds we do need two -d options to cover both regular
and generated .c files.  But in in-tree builds it suffices to
specify "-d .", so suppress the second switch.

Author: Narek Galstyan <narek.galstyan@enterprisedb.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAHsn6_xCDQWe8_vVFhtFk27_xTdyVV+Dr0yWzaooBZ6+-VH-5w@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2dc69bf953af145c6aba5dc9cebce374f6841bba

Modified Files
--------------
src/Makefile.global.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Clear out values from dropped columns during REPACK (CONCURRENTL
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Map pg_attribute_counted_by() to _Field_size_() under MSVC