pgsql: Fix incorrect calcSumX2 in numeric deserialize functions - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Fix incorrect calcSumX2 in numeric deserialize functions
Date
Msg-id E1xBNvb-00000001h17-2TDQ@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix incorrect calcSumX2 in numeric deserialize functions

calcSumX2 is used to inform the aggregate transition function whether it
should include the square of the transition value in the aggregate
state.  The deserialize functions for various numeric aggregates that do
use calcSumX2 weren't properly setting the property to true.  This does
not matter in core as we never perform any aggregate transitions after a
deserialize operation.

This fix is only required for external code which plumbs aggregate paths
together in such a way that could result in aggregate transitions being
performed after states have been deserialized.

Author: Maxime Schoemans <maxime.schoemans@enterprisedb.com>
Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
Discussion: https://postgr.es/m/FEBF5C3D-CC53-455F-AA9D-4D377A2E957C@enterprisedb.com
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/42ebc601feca2fd5eb065108ec79da12a227d66e

Modified Files
--------------
src/backend/utils/adt/numeric.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix incorrect calcSumX2 in numeric deserialize functions
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Fix incorrect output in example