pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode
Date
Msg-id E1x9hxs-000000013bt-3wUq@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix assertion in pg_get_shmem_pagesize() in single-user mode

Remove assertion that was too strict, and tripped if you queried the
pg_shmem_allocations_numa or the pg_buffercache_os_pages view in
single-user mode.

The point of the assertion was that the function should only be called
after "the server has started", but it would be OK to call it from the
postmaster, too, as long as it's after startup, specifically after
huge_pages_status has been set.  We already have a direct assertion
for that.

Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Discussion: https://www.postgresql.org/message-id/CAJTYsWV-=w5_oFgCnfAixWGc=gMa2pkDinLyGLsb4sKcDaf2FA@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/297eb6a04f870f6b1f7c15cd710dc2f30a8776e3

Modified Files
--------------
src/backend/storage/ipc/shmem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Amit Langote
Date:
Subject: pgsql: Ensure ExecutorCheckPerms_hook is called from RI fast path
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix ShmemInitStruct() reattachment in single-user mode