pgsql: Reject too many arguments in CREATE TRIGGER - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Reject too many arguments in CREATE TRIGGER
Date
Msg-id E1wwqoH-00000001I0h-1Zvc@gemulon.postgresql.org
Whole thread
List pgsql-committers
Reject too many arguments in CREATE TRIGGER

The number of trigger arguments is stored as a smallint, but there was
no check that the number of arguments fits with the catalog data type.
This could result in an invalid negative value being stored once one
defined more than INT16_MAX arguments, with an overflowed value stored
in the catalogs.

Looking at other catalogs that store a number of arguments, we have
similar protections already in place (aggregates, functions, etc.).

Reported-by: Xingwang Xiang <v3rdant.xiang@gmail.com>
Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/19627-5b72a57e332e2b3f@postgresql.org
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f0098e2fc90f8e0de8385d669bcc09d1e47ee1c8

Modified Files
--------------
src/backend/commands/trigger.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Fix GIN multiple-VACUUM-scans pending list bug.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Skip bogus find_composite_type_dependencies() call on sequences