pgsql: Add data_page_checksum_version to pg_control_checkpoint - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Add data_page_checksum_version to pg_control_checkpoint
Date
Msg-id E1wwQcV-000000016st-0BZz@gemulon.postgresql.org
Whole thread
List pgsql-committers
Add data_page_checksum_version to pg_control_checkpoint

Commit f19c0eccae added the data_checksum_version to the pg_controldata
output, but omitted a corresponding change to the pg_control_checkpoint
SQL function, which reports the same checkpoint information.  The field
is named to match what pg_control_init already reports for consistency.

The integer version reported is an implementation detail which bleeds
through, but it is quite widely used and a more holistic approach to
improving this is left as an excercise for the next major version. The
mapping between states and versions is added to the documentation to
make it easier for users.

Backpatch to v19 where online checksums were introduced.

Author: Ian Barwick <barwick@gmail.com>
Co-authored-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/CAB8KJ=hb765sE8bKC-6sh=Yp3sCjN8xs474yuBrkwyoTM2pgZA@mail.gmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/397f0fd06edc3a5b114449164c5d39c59a468b61

Modified Files
--------------
doc/src/sgml/func/func-info.sgml                 |  5 +++
doc/src/sgml/wal.sgml                            | 45 +++++++++++++++++++++++-
src/backend/utils/misc/pg_controldata.c          |  9 +++--
src/include/catalog/catversion.h                 |  2 +-
src/include/catalog/pg_proc.dat                  |  6 ++--
src/test/modules/test_checksums/t/001_basic.pl   | 18 ++++++++++
src/test/modules/test_checksums/t/004_offline.pl | 12 +++++++
7 files changed, 89 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Minor test suite cleanup
Next
From: Masahiko Sawada
Date:
Subject: pgsql: test_decoding: Don't print virtual generated columns.