pgsql: Improve wording of sequence origin warning in logical replicatio - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Improve wording of sequence origin warning in logical replicatio
Date
Msg-id E1wpeyC-000000012rA-1qz5@gemulon.postgresql.org
Whole thread
List pgsql-committers
Improve wording of sequence origin warning in logical replication.

check_publications_origin_sequences() warns when a subscription with
origin = NONE synchronizes sequence values that may have originated from
another subscription. The existing warning is phrased in terms of
copy_data and copying data, which is appropriate for table synchronization
but misleading for sequence synchronization.

Reword the warning, detail, and hint to describe sequence synchronization
and the associated origin = NONE semantics more accurately.

Also fix a typo ("rathen" -> "rather") in a comment in sequencesync.c.

Reported-by: Noah Misch <noah@leadboat.com>
Reported-by: Peter Smith <smithpb2250@gmail.com>
Author: vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19, where it was introduced
Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c7d8049682d623109a40de0c84d68e114c013c26

Modified Files
--------------
src/backend/commands/subscriptioncmds.c        | 8 ++++----
src/backend/replication/logical/sequencesync.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix issue with RANGE's DEFAULT partition pruning
Next
From: David Rowley
Date:
Subject: pgsql: Fix Hash Join performance issue when hashing NULL values