pgsql: Handle invalid and dropped databases during checksum enable - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Handle invalid and dropped databases during checksum enable
Date
Msg-id E1wonwm-00000000hfk-1R61@gemulon.postgresql.org
Whole thread
List pgsql-committers
Handle invalid and dropped databases during checksum enable

Enable errors out early with a hint when an invalid database exists,
since the worker cannot connect to it and its files stay on disk.

A worker that started but failed gets the same dropped-database
heuristic as one that failed to start, so a concurrent drop during
processing no longer aborts the whole run.  The existence check locks
the database first, otherwise a DROP DATABASE ... WITH (FORCE) which
killed the worker is still only halfway done and the database looks
like it is there to stay.

Backpatch to v19 where online checksums were introduced.

Author: Zsolt Parragi <zsolt.parragi@percona.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CAN4CZFOGdqxtZ5-6gb4apqmvoH=Z+TNH8RKJ3mVtoR1HirKQWg@mail.gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/51f55b13a4d3621244b3645a506b006decca0ec2

Modified Files
--------------
src/backend/postmaster/datachecksum_state.c    |  71 +++++++++++++++
src/test/modules/test_checksums/t/001_basic.pl | 121 +++++++++++++++++++++++++
2 files changed, 192 insertions(+)


pgsql-committers by date:

Previous
From: Masahiko Sawada
Date:
Subject: pgsql: Fix logical decoding of empty prepared transactions.
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Recheck checksum state before file_copy during CREATE DATABASE