pgsql: Fix truncation rules for base64 encoding - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Fix truncation rules for base64 encoding
Date
Msg-id E1wkitB-000d6C-0q@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix truncation rules for base64 encoding

Commit e1d917182 added support for base64url encoding, a base64 variant
intended to be safe for usage in URLs and filenames.  The padding rules
for base64url and base64 differ in that base64url require no extra '='
padding, but the commit unintentionally relaxed this requirement for
base64 as well.  Fix by making sure that the truncation logic check
for the encoding and add a test to make sure.

Backpatch down to v19 where support for base64url was introduced.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: David E. Wheeler <david@justatheory.com>
Discussion: https://postgr.es/m/3258FC72-F5E1-40B9-B5D7-64478CAF7728@yesql.se
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5f57f58179bf48805558ac0494851e93fe0eca76

Modified Files
--------------
src/backend/utils/adt/encode.c        | 4 ++--
src/test/regress/expected/strings.out | 4 ++++
src/test/regress/sql/strings.sql      | 3 +++
3 files changed, 9 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix truncation rules for base64 encoding
Next
From: Peter Eisentraut
Date:
Subject: pgsql: doc: Fix SQL quoting in example