pgsql: Add additional sanity checks when reading a blkreftable. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Add additional sanity checks when reading a blkreftable.
Date
Msg-id E1wk3wF-000Kaf-0s@gemulon.postgresql.org
Whole thread
List pgsql-committers
Add additional sanity checks when reading a blkreftable.

Code elsewhere in the system assumes that fork numbers and chunk sizes
are within bounds, so the code that reads those quantities from disk
should validate that they are. Without these additional checks, a
corrupted file can cause us to index off the end of fork number or chunk
entry arrays, potentially resulting in a crash.

Reported-by: oxsignal <awo@kakao.com> (chunk sizes)
Reported-by: Robert Haas <rhaas@postgresql.org> (fork numbers)
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: http://postgr.es/m/CA+TgmoYP8RKoBGosS7C6Fdr-GNCfyz_W1zmK=Tx1Fe0ZvzGh0g@mail.gmail.com
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ee654419d5fe7a37b230b865018dc8c1f6b9fc08

Modified Files
--------------
src/common/blkreftable.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Make max_pinned_buffers be > 0, don't just Assert that it is.
Next
From: Jeff Davis
Date:
Subject: pgsql: Fix like_fixed_prefix_ci() selectivity.