pgsql: Fix argument names in pg_clear_attribute_stats() errors - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Fix argument names in pg_clear_attribute_stats() errors
Date
Msg-id E1wjygh-000IaI-0Y@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix argument names in pg_clear_attribute_stats() errors

pg_clear_attribute_stats() checks its required arguments manually
because the function is not strict. Previously, when schemaname or
relname was passed as NULL, the error incorrectly reported the
argument name as "relation" in both cases:

    ERROR:  argument "relation" must not be null

This was misleading, especially for schemaname, and inconsistent with
the function's SQL-visible argument names.

The cause is that cleararginfo[] in attribute_stats.c used
"relation" for both the schema-name and relation-name arguments.

This commit fixes the issue by using "schemaname" and "relname" instead,
matching the function's declared argument names so that the error reports
the correct argument name.

Backpatch to v18, where pg_clear_attribute_stats() was introduced.

Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/4bf66c5e-8dd7-4ef3-8691-db67ecff6f16@tantorlabs.com
Backpatch-through: 18

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/173ea84dfdc96390ce37a3918aa660a15c4734a9

Modified Files
--------------
src/backend/statistics/attribute_stats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Fix argument names in pg_clear_attribute_stats() errors
Next
From: Fujii Masao
Date:
Subject: pgsql: Fix argument names in pg_clear_attribute_stats() errors