pgsql: Print off_t/pgoff_t consistently as %lld - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Print off_t/pgoff_t consistently as %lld
Date
Msg-id E1wh2XI-0000g9-2v@gemulon.postgresql.org
Whole thread
List pgsql-committers
Print off_t/pgoff_t consistently as %lld

This was the dominant style already, but some places used %llu
instead.  Since off_t/pgoff_t are signed types, using %lld seems a
better match, and it might handle obscure error conditions with
negative values better.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c22d2f7fd46c692c83152773387be6b731c1a4b9

Modified Files
--------------
src/bin/pg_combinebackup/reconstruct.c     | 10 +++++-----
src/bin/pg_dump/pg_backup_tar.c            |  8 ++++----
src/bin/pg_rewind/libpq_source.c           |  2 +-
src/bin/pg_verifybackup/astreamer_verify.c |  4 ++--
src/bin/pg_verifybackup/pg_verifybackup.c  |  6 +++---
5 files changed, 15 insertions(+), 15 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Don't cast pgoff_t to possibly 32-bit types for output
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Add reference to CREATE PROCEDURE on CREATE FUNCTION