pgsql: Update GROUP BY ALL comments about window functions - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Update GROUP BY ALL comments about window functions
Date
Msg-id E1wgzhC-001hqK-03@gemulon.postgresql.org
Whole thread
List pgsql-committers
Update GROUP BY ALL comments about window functions

When GROUP BY ALL was added in commit ef38a4d9756, the SQL standard
working draft was silent on what to do with window functions.  This
has now been fixed in the SQL standard working draft.  Update the
documentation and code comments about that.

Also make the documentation more specific that we are only talking
about aggregate functions referring to the same query level, which is
another thing that has been made more precise in the SQL standard
working draft since.

The PostgreSQL implementation was already doing the right thing for
both aspects, so no functionality changes.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion:
https://www.postgresql.org/message-id/flat/CAHM0NXjz0kDwtzoe-fnHAqPB1qA8_VJN0XAmCgUZ%2BiPnvP5LbA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2ce74583652fb4cd29299a220ff31043adf5c96e

Modified Files
--------------
doc/src/sgml/queries.sgml         | 2 +-
doc/src/sgml/ref/select.sgml      | 3 ++-
src/backend/parser/parse_clause.c | 4 +---
3 files changed, 4 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Amit Langote
Date:
Subject: pgsql: Enforce RETURNING typmod on SQL/JSON DEFAULT behavior expression
Next
From: Etsuro Fujita
Date:
Subject: pgsql: postgres_fdw: Report ANALYZE to pgstats after importing statisti