pgsql: Fix psql's pager selection for wrapped expanded output. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix psql's pager selection for wrapped expanded output.
Date
Msg-id E1wgV46-001V2X-1A@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix psql's pager selection for wrapped expanded output.

psql decided whether to use the pager in expanded output without
accounting for possible wrapping of column values.  This could
allow it to not use the pager in cases where it should do so.

To fix, move the IsPagerNeeded decision in print_aligned_vertical()
down until after the wrapped data width is known.  Then, if we're in
wrapped mode, prepare a width_wrap array specifying that width (which,
in vertical mode, is the same for all columns).

This is fixing an omission in 27da1a796, so back-patch to v19
where that came in.

Author: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/A44110E7-6A03-4C67-95AD-527192A6C768@gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/07abbc93ba5ba41b60927221db92bc73f75fd1ba

Modified Files
--------------
src/bin/psql/t/030_pager.pl |  5 +++++
src/fe_utils/print.c        | 53 ++++++++++++++++++++++++++++++---------------
2 files changed, 40 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Simplify dxsyn_lexize().
Next
From: Michael Paquier
Date:
Subject: pgsql: Improve checks and error messages of pgstat_register_kind()