pgsql: Fix REPACK CONCURRENTLY for stored generated columns - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Fix REPACK CONCURRENTLY for stored generated columns
Date
Msg-id E1wfb3g-0019jU-2x@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix REPACK CONCURRENTLY for stored generated columns

In order to replay concurrent changes, REPACK CONCURRENTLY needs the
pg_attrdef tuples for the transient table to be there, in case a tuple
is modified concurrently with REPACK and requires to store the value
from the generated column (which, with the current arrangements, means
all tuples concurrently updated or inserted).  Fix by creating a copy of
them from the original table.  Add a test that tickles the bug.

Author: Antonin Houska <ah@cybertec.at>
Reported-by: Ewan Young <kdbase.hack@gmail.com>
Diagnosed-by: Ewan Young <kdbase.hack@gmail.com>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/CAON2xHMrELwx9vKg6niSf8fMBA=-MGXmG=MPQU6+vMVhGjF8kQ@mail.gmail.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fb284f2f9bdb9dd5e866132f7d0b8eeaa972e521

Modified Files
--------------
src/backend/commands/repack.c                      | 103 ++++++++++++++++++++-
.../modules/injection_points/specs/repack.spec     |   3 +-
2 files changed, 104 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Prevent dropping the last label from a property graph element
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix tracing of BackendKeyData and CancelRequest