pgsql: Don't cast off_t to 32-bit type for output, bug fix - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Don't cast off_t to 32-bit type for output, bug fix
Date
Msg-id E1weprp-000sxJ-19@gemulon.postgresql.org
Whole thread
List pgsql-committers
Don't cast off_t to 32-bit type for output, bug fix

off_t is most likely a 64-bit integer, so casting it to a 32-bit type
for output could lose data.  There are more issues like this in the
tree, but this is an instance where this could actually happen in
practice, since base backups are routinely larger than 4 GB.  So this
is separated out as a bug fix.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4d99e6ed640e3a214875b814d489c4d8ce8f77b1

Modified Files
--------------
src/backend/backup/basebackup_server.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Use C11 alignas instead of pg_attribute_aligned
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Split dry-run messages into primary and detail