pgsql: Switch maximum of GUC huge_page_size to MAX_KILOBYTES - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Switch maximum of GUC huge_page_size to MAX_KILOBYTES
Date
Msg-id E1wdJ6t-000M2n-0b@gemulon.postgresql.org
Whole thread
List pgsql-committers
Switch maximum of GUC huge_page_size to MAX_KILOBYTES

As documented in guc.h, MAX_KILOBYTES is used to cap GUC parameters that
are measured in kilobytes of memory.  This way, size_t values can fit in
builds where sizeof(size_t) is 4 bytes.

Unfortunately, huge_page_size has missed this aspect, causing
calculation failures when setting this GUC to a value higher than
MAX_KILOBYTES, up to INT_MAX.

Oversight in d2bddc2500fb.  No backpatch is done, based on the lack of
complaints.

Reported-by: Daria Shanina <vilensipkdm@gmail.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20260626.132415.904994526137946499.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dbaa4dc3c8dd77a0e1c977024d4ae150e00456b3

Modified Files
--------------
src/backend/utils/misc/guc_parameters.dat | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Make crosstabview honor boolean/null display settings
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Move FOR PORTION OF volatile check into planner