pgsql: Update JIT tuple deforming code for virtual generated columns - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Update JIT tuple deforming code for virtual generated columns
Date
Msg-id E1waPsO-000wqi-0D@gemulon.postgresql.org
Whole thread
List pgsql-committers
Update JIT tuple deforming code for virtual generated columns

The JIT deforming code contains an optimization that determines which
columns are guaranteed to exist in the tuple.  That's used to allow
skipping of reading the tuple's natts when the code only needs to deform
attributes that are guaranteed to always exist in all tuples.  83ea6c540
missed updating this code to account for VIRTUAL generated columns.
These are stored as NULLs in the tuple, but may be defined as NOT NULL.
This could result in the code thinking more columns are guaranteed to
exist than actually do.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Backpatch-through: 18
Discussion: https://postgr.es/m/1151393.1781734980@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dc5116780846951a409d788479a9e9fa6edd9f07

Modified Files
--------------
src/backend/jit/llvm/llvmjit_deform.c           | 36 ++++++++++++++++---------
src/test/regress/expected/generated_stored.out  | 14 ++++++++++
src/test/regress/expected/generated_virtual.out | 32 ++++++++++++++++++++++
src/test/regress/sql/generated_stored.sql       | 14 ++++++++++
src/test/regress/sql/generated_virtual.sql      | 15 +++++++++++
5 files changed, 99 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix comments on data checksum cost settings
Next
From: David Rowley
Date:
Subject: pgsql: Update JIT tuple deforming code for virtual generated columns