pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
Date
Msg-id E1waFWZ-000tKW-1x@gemulon.postgresql.org
Whole thread
List pgsql-committers
hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding loop.

Add CHECK_FOR_INTERRUPTS() to the while loop in plperl_to_hstore()
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely.  (We looked at detecting such circular
references, but it seems more trouble than it's worth.)

This is a follow-up to da82fbb8f, which fixed the same issue in
SV_to_JsonbValue() in jsonb_plperl.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/60a1d712a4726fdb44842fd06168715d8534b403

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 9 +++++++++
1 file changed, 9 insertions(+)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Avoid errors during DROP SUBSCRIPTION when slot_name is NONE.
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix comments on data checksum cost settings