IS JSON/JSON(): Protect against expressions uncoercible to text
transformJsonParseArg() was not careful enough on generation of
transformed expressions when starting from expressions that are not
coercible to text but are in the string type category: it failed to
verify that coerce_to_target_type() succeeds, and returned a NULL
pointer. This leads to a later NULL dereference and crash at executor
time.
This escaped noticed because it cannot happen for built-in types, all of
which have casts to text. Only user-created types are potentially
problematic.
Fix by raising an error when a cast to text doesn't exist.
This mistake came in with commit 6ee30209a6f1.
Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Reported-by: Chi Zhang <798604270@qq.com>
Reviewed-by: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Backpatch-through: 16
Discussion: https://postgr.es/m/19491-7aafc221ec63f288@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7dd15325952fe85521b1fefea3ad39cf1b46e0c8
Modified Files
--------------
src/backend/nodes/makefuncs.c | 2 ++
src/backend/parser/parse_expr.c | 10 +++++++++
src/test/regress/expected/sqljson.out | 38 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/sqljson.sql | 22 ++++++++++++++++++++
4 files changed, 72 insertions(+)
