pgsql: dict_synonym.c: remove incorrect outlen. - Mailing list pgsql-committers

From Jeff Davis
Subject pgsql: dict_synonym.c: remove incorrect outlen.
Date
Msg-id E1wWf71-001dTK-20@gemulon.postgresql.org
Whole thread
List pgsql-committers
dict_synonym.c: remove incorrect outlen.

Previously, outlen was miscalculated if case_sensitive was false and
str_tolower() changed the byte length of the string. If outlen was too
large, pnstrdup() would stop at the NUL terminator, preventing
overrun. But if outlen was too small, it would cause truncation.

Fix by just removing outlen. It was only used in a single site, which
could just as well use pstrdup().

Discussion: https://postgre.es/m/1101e1a3afbbabb503317069c40374b82e6f4cac.camel@j-davis.com
Reviewed-by: Tristan Partin <tristan@partin.io>
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9234e333711ef9875a4cef31889e88439421c396

Modified Files
--------------
src/backend/tsearch/dict_synonym.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix FOR PORTION OF for inheritance children
Next
From: Jeff Davis
Date:
Subject: pgsql: dict_synonym.c: remove incorrect outlen.