pgsql: Improve REPACK (CONCURRENTLY) error when wal_level < replica - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Improve REPACK (CONCURRENTLY) error when wal_level < replica
Date
Msg-id E1wSaQe-001VCf-2W@gemulon.postgresql.org
Whole thread
List pgsql-committers
Improve REPACK (CONCURRENTLY) error when wal_level < replica

The error emitted when REPACK (CONCURRENTLY) is run with too low a
wal_level is thrown by CheckSlotRequirements(), which is a bit
mysterious when the user doesn't know what's up.  Add an upfront check
in check_concurrent_repack_requirements() for a more explicit, REPACK-
centered report, which is easier to understand -- this also saves
starting the worker just to have it die immediately.

Author: Baji Shaik <baji.pgdev@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CA+fm-ROdgh0rEVuXoViBk4TVgjodrN=MTR_RYuOuKLZ9voX4YA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/43649b6a53e9b3964e921cc962f5c977bce688fd

Modified Files
--------------
src/backend/commands/repack.c | 9 +++++++++
1 file changed, 9 insertions(+)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: postgres_fdw: Fix whitespace violation in connection.c
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Fix some minor issues in repack ereport()s