pgsql: Fix self-deadlock when replaying WAL generated by older minor ve - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix self-deadlock when replaying WAL generated by older minor ve
Date
Msg-id E1wSADk-001JyO-0M@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix self-deadlock when replaying WAL generated by older minor version

Commit 77dff5d937 introduced a SimpleLruWriteAll() call when replaying
multixact WAL records generated by older minor versions. However,
SimpleLruWriteAll() acquires the SLRU lock and on v16 and below, it's
called while already holding the lock, leading to self-deadlock.
Version 17 and 18 did not have that problem, because in those versions
the lock is acquired later in the function.

To fix, acquire MultiXactOffsetSLRULock later in RecordNewMultiXact(),
at the same place where it's acquired on version 17 and 18.

Author: Andrey Borodin <x4mmm@yandex-team.ru>
Reported-by: Radim Marek <radim@boringsql.com>
Discussion: https://www.postgresql.org/message-id/19490-9c59c6a583513b99@postgresql.org
Backpatch-through: 14-16

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2dfe75f9844f29f8b2621ed68ee12e577f05e7f3

Modified Files
--------------
src/backend/access/transam/multixact.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix procLatch ownership race in ProcKill()
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Remove incorrect OpenSSL feature guards