pgsql: Fix SPLIT PARTITION range bound validation with DEFAULT - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Fix SPLIT PARTITION range bound validation with DEFAULT
Date
Msg-id E1wPI6O-000GEp-2L@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix SPLIT PARTITION range bound validation with DEFAULT

When splitting a range partition and defining a new DEFAULT partition, the
validation checked the lower bound of the first explicit partition and the
upper bound of explicit partitions only when they were not first.  If there
was exactly one explicit non-DEFAULT partition, its upper bound was therefore
not checked.

This could allow the replacement partition to extend beyond the upper bound
of the partition being split, potentially overlapping another existing
partition.

Fix this by checking the upper bound whenever the explicit partition is the
last one.  Add a regression test covering the single explicit partition plus
DEFAULT case.

Author: Chao Li <lic@highgo.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Zhenwei Shang <a934172442@gmail.com>
Reviewed-by: Dmitry Koval <d.koval@postgrespro.ru>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
Discussion: https://postgr.es/m/C18878AB-DEB2-4A61-9995-A035DD644B81@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9354896920e4b2efd3b1b88caaea4e0c9071acb2

Modified Files
--------------
src/backend/partitioning/partbounds.c         |  3 ++-
src/test/regress/expected/partition_split.out | 16 ++++++++++++++++
src/test/regress/sql/partition_split.sql      | 15 +++++++++++++++
3 files changed, 33 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Fix COPY FROM ON_ERROR SET_NULL with selective column list
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Fix REPACK decoding worker not cleaned up on FATAL exit