pgsql: Use schema-qualified names in EXCEPT clause error messages. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Use schema-qualified names in EXCEPT clause error messages.
Date
Msg-id E1wLCwb-000oB5-1A@gemulon.postgresql.org
Whole thread
List pgsql-committers
Use schema-qualified names in EXCEPT clause error messages.

Error messages in check_publication_add_relation() previously reported
only the relation name when a table in an EXCEPT clause could not be
processed, which is ambiguous when the same name exists in multiple
schemas. Use schema-qualified names instead, consistent with other error
messages that reference relation names.

Author: Dilip Kumar <dilipbalaut@gmail.com>
Author: vignesh C <vignesh21@gmail.com>
Reviewed-by: shveta malik <shveta.malik@gmail.com>
Reviewed-by: Euler Taveira <euler@eulerto.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Peter Smith <smithpb2250@gmail.com>
Discussion: https://postgr.es/m/CAFiTN-scG7b11Jsp+VoDRT8ZFE84eSKLcDsSB18dZ8AaP=R-mw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a49b9cfd72d89a8fd68c90e84c38aa7e2ada756b

Modified Files
--------------
src/backend/catalog/pg_publication.c      | 17 ++++++++++++-----
src/backend/utils/adt/ruleutils.c         | 12 ++----------
src/backend/utils/cache/lsyscache.c       | 20 ++++++++++++++++++++
src/backend/utils/cache/relcache.c        | 10 ++++++++++
src/include/utils/lsyscache.h             |  1 +
src/include/utils/relcache.h              |  1 +
src/test/regress/expected/publication.out |  2 +-
7 files changed, 47 insertions(+), 16 deletions(-)


pgsql-committers by date:

Previous
From: Etsuro Fujita
Date:
Subject: pgsql: postgres_fdw: Fix syntax error in fetch_attstats().
Next
From: Richard Guo
Date:
Subject: pgsql: Enforce RETURNING typmod for empty-set JSON_ARRAY(query)