pgsql: Skip other sessions' temp tables in REPACK, CLUSTER, and VACUUM - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Skip other sessions' temp tables in REPACK, CLUSTER, and VACUUM
Date
Msg-id E1wKGgN-000SzW-2A@gemulon.postgresql.org
Whole thread
List pgsql-committers
Skip other sessions' temp tables in REPACK, CLUSTER, and VACUUM FULL

get_tables_to_repack() and get_all_vacuum_rels() were including other
sessions' temporary tables in their output work list, causing REPACK,
CLUSTER and VACUUM FULL (when executed without a table list) to attempt
to acquire AccessExclusiveLock on them, potentially blocking for an
extended time.  Fix by skipping other-session temp tables early, before
they are added to the list.

This issue is ancient, but there have been no complaints about it that I
know of, so I'm opting for not backpatching at present.

Author: Jim Jones <jim.jones@uni-muenster.de>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Discussion: https://postgr.es/m/0b555318-2bf2-46df-9377-09629a2a59db@uni-muenster.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a0a0c0c20ec5f8787bb1be5f476c4e59f6810634

Modified Files
--------------
src/backend/commands/repack.c | 25 ++++++++++++++++++++++++-
src/backend/commands/vacuum.c |  5 +++++
2 files changed, 29 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Add missing guard for __builtin_constant_p
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Document deprecated --wal-directory option for pg_verifybackup