pgsql: Make ExecForPortionOfLeftovers() obey SRF protocol. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Make ExecForPortionOfLeftovers() obey SRF protocol.
Date
Msg-id E1wEpVc-001s8Y-1G@gemulon.postgresql.org
Whole thread
List pgsql-committers
Make ExecForPortionOfLeftovers() obey SRF protocol.

Before each call to the SRF, initialize isnull and isDone, as per the
comments for struct ReturnSetInfo.  This fixes a Coverity warning
about rsi.isDone not being initialized.  The built-in
{multi,}range_minus_multi functions don't return without setting it,
but a user-supplied function might not be as accommodating.

We also add statistics tracking around the function call, which
will be expected once user-defined withoutPortionProcs functions
are supported, and a cross-check on rsi.returnMode just for
paranoia's sake.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Co-authored-by: Paul A Jungwirth <pj@illuminatedcomputing.com>
Discussion: https://postgr.es/m/4126231.1776622202@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/207cb2abcba00f78d57cdaca896f41c9453b0f2f

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: REPACK: do not require REPLICATION or LOGIN
Next
From: Tom Lane
Date:
Subject: pgsql: Clean up all relid fields of RestrictInfos during join removal.