pgsql: pg_plan_advice: Handle non-repeatable TABLESAMPLE scans. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: pg_plan_advice: Handle non-repeatable TABLESAMPLE scans.
Date
Msg-id E1wCGgn-000mxv-0N@gemulon.postgresql.org
Whole thread
List pgsql-committers
pg_plan_advice: Handle non-repeatable TABLESAMPLE scans.

When a tablesample routine says that it is not repeatable across
scans, set_tablesample_rel_pathlist will (usually) materialize it,
confusing pg_plan_advice's plan walker machinery. To fix, update that
machinery to view such Material paths as essentially an extension of
the underlying scan.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: http://postgr.es/m/CA+TgmobOOmmXSJz3e+cjTY-bA1+W0dqVDqzxUBEvGtW62whYGg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3311ccc3d24bf83fb26a8af81ea68a8fcc295c26

Modified Files
--------------
contrib/pg_plan_advice/Makefile          |  2 ++
contrib/pg_plan_advice/expected/scan.out | 38 ++++++++++++++++++++++++++++++++
contrib/pg_plan_advice/pgpa_join.c       | 12 ++++++----
contrib/pg_plan_advice/pgpa_scan.c       | 11 +++++++++
contrib/pg_plan_advice/pgpa_walker.c     | 29 ++++++++++++++++++++++++
contrib/pg_plan_advice/pgpa_walker.h     |  1 +
contrib/pg_plan_advice/sql/scan.sql      | 12 ++++++++++
7 files changed, 101 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Explicitly forbid non-top-level WAIT FOR execution
Next
From: Robert Haas
Date:
Subject: pgsql: pg_plan_advice: Add alternatives test to Makefile.