pgsql: pg_createsubscriber: Use logging.c log file callback - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: pg_createsubscriber: Use logging.c log file callback
Date
Msg-id E1wCD0D-000lPt-0v@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_createsubscriber: Use logging.c log file callback

This reverts commit 6b5b7eae3ae, where a new logging API layer was
introduced locally in pg_createsubscriber.  Instead, use the log file
callback introduced in logging.c.  This new approach is simpler,
eliminates code duplication, and doesn't require any caller changes or
NLS updates (which the previous commit missed).

Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion:
https://www.postgresql.org/message-id/flat/CAEqnbaUthOQARV1dscGvB_EsqC-YfxiM6rWkVDHc%2BG%2Bf4oSUHw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/847336ba53af2d140563cdf9f2b0c4f678378a54

Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 832 ++++++++++------------------
1 file changed, 279 insertions(+), 553 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Fix capitalization in publication describe output.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: pg_createsubscriber: Remove separate logfile_open() function