pgsql: Fix estimate_array_length error with set-operation array coercio - Mailing list pgsql-committers

From Richard Guo
Subject pgsql: Fix estimate_array_length error with set-operation array coercio
Date
Msg-id E1wBSzX-000QOc-2z@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix estimate_array_length error with set-operation array coercions

When a nested set operation's output type doesn't match the parent's
expected type, recurse_set_operations builds a projection target list
using generate_setop_tlist with varno 0.  If the required type
coercion involves an ArrayCoerceExpr, estimate_array_length could be
called on such a Var, and would pass it to examine_variable, which
errors in find_base_rel because varno 0 has no valid relation entry.

Fix by skipping the statistics lookup for Vars with varno 0.

Bug introduced by commit 9391f7152.  Back-patch to v17, where
estimate_array_length was taught to use statistics.

Reported-by: Justin Pryzby <pryzby@telsasoft.com>
Author: Tender Wang <tndrwang@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/adjW8rfPDkplC7lF@pryzbyj2023
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/77d0e82e58854cfa5e2c4f365a97f16c0d91c394

Modified Files
--------------
src/backend/utils/adt/selfuncs.c    | 12 ++++++++++++
src/test/regress/expected/union.out | 17 +++++++++++++++++
src/test/regress/sql/union.sql      |  4 ++++
3 files changed, 33 insertions(+)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: read_stream: Remove obsolete comment.
Next
From: Michael Paquier
Date:
Subject: pgsql: Honor passed-in database OIDs in pgstat_database.c