pgsql: instrumentation: Move ExecProcNodeInstr to allow inlining - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: instrumentation: Move ExecProcNodeInstr to allow inlining
Date
Msg-id E1wAIPY-003TvL-1o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
instrumentation: Move ExecProcNodeInstr to allow inlining

This moves the implementation of ExecProcNodeInstr, the ExecProcNode variant
that gets used when instrumentation is on, to be defined in instrument.c
instead of execProcNode.c, and marks functions it uses as inline.

This allows compilers to generate an optimized implementation, and shows a 4
to 12% reduction in instrumentation overhead for queries that move lots of
rows.

Author: Lukas Fittl <lukas@fittl.com>
Suggested-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CAP53PkzdBK8VJ1fS4AZ481LgMN8f9mJiC39ZRHqkFUSYq6KWmg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/544000288ec8f7dc6a1e0285821adc47324ecd33

Modified Files
--------------
src/backend/executor/execProcnode.c | 20 --------------------
src/backend/executor/instrument.c   | 37 +++++++++++++++++++++++++++++++------
src/include/executor/executor.h     |  7 +++++++
3 files changed, 38 insertions(+), 26 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Add EXPLAIN (IO) instrumentation for TidRangeScan
Next
From: Fujii Masao
Date:
Subject: pgsql: Fix slotsync worker blocking promotion when stuck in wait