pgsql: Fix WITHOUT OVERLAPS' interaction with domains. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix WITHOUT OVERLAPS' interaction with domains.
Date
Msg-id E1wABQx-003ROY-0H@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix WITHOUT OVERLAPS' interaction with domains.

UNIQUE/PRIMARY KEY ... WITHOUT OVERLAPS requires the no-overlap
column to be a range or multirange, but it should allow a domain
over such a type too.  This requires minor adjustments in both
the parser and executor.

In passing, fix a nearby break-instead-of-continue thinko in
transformIndexConstraint.  This had the effect of disabling
parse-time validation of the no-overlap column's type in the context
of ALTER TABLE ADD CONSTRAINT, if it follows a dropped column.
We'd still complain appropriately at runtime though.

Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Paul A Jungwirth <pj@illuminatedcomputing.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CACJufxGoAmN_0iJ=hjTG0vGpOSOyy-vYyfE+-q0AWxrq2_p5XQ@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/49f3cb453b9b86b771b0a15393893fb317e35572

Modified Files
--------------
src/backend/executor/execIndexing.c            | 12 ++++++--
src/backend/parser/parse_utilcmd.c             | 17 +++++++----
src/test/regress/expected/without_overlaps.out | 39 ++++++++++++++++++++++++++
src/test/regress/sql/without_overlaps.sql      | 31 ++++++++++++++++++++
4 files changed, 91 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Allow retrieving x86 TSC frequency/flags from CPUID
Next
From: Tomas Vondra
Date:
Subject: pgsql: Switch EXPLAIN to unaligned output for json/xml/yaml