pgsql: Allow logical replication snapshots to be database-specific - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Allow logical replication snapshots to be database-specific
Date
Msg-id E1wA3jl-003Nb4-2o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow logical replication snapshots to be database-specific

By default, the logical decoding assumes access to shared catalogs, so
the snapshot builder needs to consider cluster-wide XIDs during startup.
That in turn means that, if any transaction is already running (and has
XID assigned), the snapshot builder needs to wait for its completion, as
it does not know if that transaction performed catalog changes earlier.

A possible problem with this concept is that if REPACK (CONCURRENTLY) is
running in some database, backends running the same command in other
databases get stuck until the first one has committed. Thus only a
single backend in the cluster can run REPACK (CONCURRENTLY) at any time.
Likewise, REPACK (CONCURRENTLY) can block walsenders starting on behalf
of subscriptions throughout the cluster.

This patch adds a new option to logical replication output plugin, to
declare that it does not use shared catalogs (i.e. catalogs that can be
changed by transactions running in other databases in the cluster). In
that case, no snapshot the backend will use during the decoding needs to
contain information about transactions running in other databases. Thus
the snapshot builder only needs to wait for completion of transactions
in the current database.

Currently we only use this option in the REPACK background worker. It
could possibly be used in the plugin for logical replication too,
however that would need thorough analysis of that plugin.

Bump WAL version number, due to a new field in xl_running_xacts.

Author: Antonin Houska <ah@cybertec.at>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/90475.1775218118@localhost

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0d3dba38c777384a9dd7dffe924355c9683a6b71

Modified Files
--------------
contrib/pg_visibility/pg_visibility.c       |  4 +-
doc/src/sgml/logicaldecoding.sgml           |  4 ++
src/backend/access/index/genam.c            |  8 ++++
src/backend/access/rmgrdesc/standbydesc.c   |  2 +
src/backend/access/transam/xlog.c           |  2 +-
src/backend/access/transam/xlogfuncs.c      |  2 +-
src/backend/postmaster/bgwriter.c           |  2 +-
src/backend/replication/logical/decode.c    | 17 +++++++-
src/backend/replication/logical/logical.c   |  3 ++
src/backend/replication/logical/snapbuild.c | 63 +++++++++++++++++++++++++++--
src/backend/replication/pgrepack/pgrepack.c |  7 ++++
src/backend/replication/slot.c              |  2 +-
src/backend/storage/ipc/procarray.c         | 23 ++++++++++-
src/backend/storage/ipc/standby.c           | 24 ++++++++++-
src/include/access/xlog_internal.h          |  2 +-
src/include/miscadmin.h                     |  9 +++++
src/include/replication/output_plugin.h     |  1 +
src/include/replication/snapbuild.h         |  3 +-
src/include/storage/procarray.h             |  2 +-
src/include/storage/standby.h               |  3 +-
src/include/storage/standbydefs.h           |  1 +
21 files changed, 166 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Avoid different-size pointer-to-integer cast
Next
From: Tomas Vondra
Date:
Subject: pgsql: Use add_size/mul_size for index instrumentation size calculation