pgsql: Avoid unsafe access to negative index in a TupleDesc. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid unsafe access to negative index in a TupleDesc.
Date
Msg-id E1w9oax-003Gzp-2D@gemulon.postgresql.org
Whole thread
List pgsql-committers
Avoid unsafe access to negative index in a TupleDesc.

Commit aa606b931 installed a test that would reference a nonexistent
TupleDesc array entry if a system column is used in COPY FROM WHERE.
Typically this would be harmless, but with bad luck it could result
in a phony "generated columns are not supported in COPY FROM WHERE
conditions" error, and at least in principle it could cause SIGSEGV.
(Compare 570e2fcc0 which fixed the identical problem in another
place.)  Also, since c98ad086a it throws an Assert instead.

In the back branches, just guard the test to make it a safe no-op for
system columns.  Commit 21c69dc73 installed a more aggressive answer
in master.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/6f435023-8ab6-47c2-ba07-035d0c4212f9@gmail.com
Backpatch-through: 14-18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/11c2c0cc8d7c9fb0b68390b2b3550b54cf045dbc

Modified Files
--------------
src/backend/commands/copy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Rename cluster.c to repack.c (and corresponding .h)
Next
From: Masahiko Sawada
Date:
Subject: pgsql: Allow autovacuum to use parallel vacuum workers.