pgsql: Fix volatile function evaluation in eager aggregation - Mailing list pgsql-committers

From Richard Guo
Subject pgsql: Fix volatile function evaluation in eager aggregation
Date
Msg-id E1w9a7i-003Aa4-1i@gemulon.postgresql.org
Whole thread
List pgsql-committers
Fix volatile function evaluation in eager aggregation

Pushing aggregates containing volatile functions below a join can
violate volatility semantics by changing the number of times the
function is executed.

Here we check the Aggref nodes in the targetlist and havingQual for
volatile functions and disable eager aggregation when such functions
are present.

Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com>
Discussion: https://postgr.es/m/CAMbWs48A53PY1Y4zoj7YhxPww9fO1hfnbdntKfA855zpXfVFRA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3a08a2a8b4fd36a9fa0da0253d1ca053c19047d5

Modified Files
--------------
src/backend/optimizer/plan/initsplan.c        | 11 ++++++++
src/test/regress/expected/eager_aggregate.out | 38 +++++++++++++++++++++++++++
src/test/regress/sql/eager_aggregate.sql      | 14 ++++++++++
3 files changed, 63 insertions(+)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Add wal_sender_shutdown_timeout GUC to limit shutdown wait for r
Next
From: Fujii Masao
Date:
Subject: pgsql: Simplify redundant current_database() subqueries in stats.sql re