pgsql: Make data checksum tests more resilient for slow machines - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Make data checksum tests more resilient for slow machines
Date
Msg-id E1w8mxd-002oRr-2o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make data checksum tests more resilient for slow machines

The test for re-running checksum enabling was only checking for the
data checksum state to transition to 'on', but didn't account for
the launcher process having had time to exit, thus getting an error
instead of the expected no-op.  Adding a pg_stat_activity check for
the launcher exiting resolves the error, verified by inducing delay
in the launcher.

Also wrap a variable only used in injection point tests within the
correct USE macros to avoid warning for an unused variable.

All per the buildfarm.

Author: Daniel Gustafsson <daniel@yesql.se>
Reported-by: Buildfarm
Discussion: https://postgr.es/m/1CB288C9-564B-4664-B096-C2F4377D17AB@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0036232ba8fb282979cff16c8751a361cb85fe76

Modified Files
--------------
src/test/modules/test_checksums/t/001_basic.pl   | 6 +++++-
src/test/modules/test_checksums/test_checksums.c | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Add elevel parameter to relation_needs_vacanalyze().
Next
From: Jacob Champion
Date:
Subject: pgsql: oauth: Let validators provide failure DETAILs