pgsql: Remove redundant SetLatch() calls in interrupt handling function - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Remove redundant SetLatch() calls in interrupt handling function
Date
Msg-id E1w8JTj-002ce8-1d@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove redundant SetLatch() calls in interrupt handling functions

Interrupt handling functions (e.g., HandleCatchupInterrupt(),
HandleParallelApplyMessageInterrupt()) are called only by
procsignal_sigusr1_handler(), which already calls SetLatch()
for the current process at the end of its processing.
Therefore, these interrupt handling functions do not need to
call SetLatch() themselves.

However, previously, some of these functions redundantly
called SetLatch(). This commit removes those unnecessary
calls.

While duplicate SetLatch() calls are redundant, they are
harmless, so this change is not backpatched.

Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Dilip Kumar <dilipbalaut@gmail.com>
Discussion: https://postgr.es/m/CALj2ACWd5apddj6Cd885WwJ6LquYu_G81C4GoR4xSoDV1x-FEA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/57706799186aa7971b78cab8911fb2604833de0f

Modified Files
--------------
src/backend/access/transam/parallel.c                 | 2 +-
src/backend/commands/async.c                          | 3 +--
src/backend/replication/logical/applyparallelworker.c | 2 +-
src/backend/replication/walsender.c                   | 2 ++
src/backend/storage/ipc/sinval.c                      | 3 +--
5 files changed, 6 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Check for __cpuidex and __get_cpuid_count separately
Next
From: Tom Lane
Date:
Subject: pgsql: Harden astreamer tar parsing logic against archives it can't han