pgsql: perl tap: Show die reason in TAP output - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: perl tap: Show die reason in TAP output
Date
Msg-id E1w8H7D-002bgV-01@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
perl tap: Show die reason in TAP output

Install a $SIG{__DIE__} handler in the INIT block of Utils.pm that emits
the die message as a TAP diagnostic.  Previously, an unexpected die
(e.g. from safe_psql) produced only "no plan was declared" with no
indication of the actual error.  The handler also calls done_testing()
to suppress that confusing message.

Dies during compilation ($^S undefined) and inside eval ($^S == 1) are
left alone.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/DFYFWM053WHS.10K8ZPJ605UFK@jeltef.nl
Discussion: https://postgr.es/m/20220222181924.eehi7o4pmneeb4hm%40alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/76540fdedf405c01518007bef3bdd96e0b96d390

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Utils.pm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: jit: Change the default to off.
Next
From: John Naylor
Date:
Subject: pgsql: Check for __cpuidex and __get_cpuid_count separately