pgsql: perl tap: Show failed command output - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: perl tap: Show failed command output
Date
Msg-id E1w8H7C-002bgT-3C@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
perl tap: Show failed command output

Capture stdout and stderr from command_ok() and command_fails() and emit
them as TAP diagnostics on failure.  Output is truncated to the first
and last 30 lines per channel to avoid flooding.

A new helper _diag_command_output() is introduced in Utils.pm so
both functions share the same truncation and formatting logic.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/DFYFWM053WHS.10K8ZPJ605UFK@jeltef.nl

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1402b8d2fc70faa5154cbc26cab8c4ac384880db

Modified Files
--------------
src/bin/pg_ctl/t/001_start_stop.pl     |  2 +-
src/test/perl/PostgreSQL/Test/Utils.pm | 53 ++++++++++++++++++++++++++++++----
2 files changed, 48 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: jit: Change the default to off.
Next
From: John Naylor
Date:
Subject: pgsql: Check for __cpuidex and __get_cpuid_count separately