pgsql: pg_regress: Include diffs in TAP output - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: pg_regress: Include diffs in TAP output
Date
Msg-id E1w8H7C-002bgR-36@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_regress: Include diffs in TAP output

When pg_regress fails it is often tedious to find the actual diffs,
especially in CI where you must navigate a file browser.  Emit the first
80 lines of the combined regression.diffs as TAP diagnostics so the
failure reason is visible directly in the test output.

The line limit is across all failing tests in a single pg_regress run to
avoid flooding when a crash causes every subsequent test to fail.

New DIAG_DETAIL / DIAG_END tap output types are added, mirroring the
existing NOTE_DETAIL / NOTE_END pair, so that long diff lines can be
emitted without spurious '#' prefixes on continuation lines.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/DFYFWM053WHS.10K8ZPJ605UFK@jeltef.nl

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5720ae01436480c1dcdd34ece0c3d83b00844bca

Modified Files
--------------
src/test/regress/pg_regress.c | 93 ++++++++++++++++++++++++++++++++++++++-----
1 file changed, 82 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: jit: Change the default to off.
Next
From: John Naylor
Date:
Subject: pgsql: Check for __cpuidex and __get_cpuid_count separately