pgsql: read_stream: Issue IO synchronously while in fast path - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: read_stream: Issue IO synchronously while in fast path
Date
Msg-id E1w856w-002Wbz-0B@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
read_stream: Issue IO synchronously while in fast path

While in fast-path, execute any IO that we might encounter synchronously.
Because we are, in that moment, not reading ahead, dispatching any occasional
IO to workers has the dispatch overhead, without any realistic chance of the
IO completing before we need it.

This helps io_method=worker performance for workloads that have only
occasional cache misses, but where those occasional misses still take long
enough to matter.  It is likely this is only measurable with fast local
storage or workloads with the data in the kernel page cache, as with remote
storage the IO latency, not the dispatch-to-worker latency, is the determining
factor.

Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Discussion: https://postgr.es/m/f3xxfrkafjxpyqxywcxricxgyizjirfceychyxsgn7bwjp5eda@kwbduhy7tfmu
Discussion: https://postgr.es/m/CAH2-Wz%3DkMg3PNay96cHMT0LFwtxP-cQSRZTZzh1Cixxf8G%3Dzrw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cceb1bf45e3a12a859c1453bd53925b95d1b0cf1

Modified Files
--------------
src/backend/storage/aio/read_stream.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Make ShmemIndex visible in the pg_shmem_allocations view
Next
From: Andres Freund
Date:
Subject: pgsql: read_stream: Prevent distance from decaying too quickly