pgsql: Fix test_aio read_buffers() to work without cassert - Mailing list pgsql-committers

From Melanie Plageman
Subject pgsql: Fix test_aio read_buffers() to work without cassert
Date
Msg-id E1w7ePH-002Lkx-0y@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix test_aio read_buffers() to work without cassert

In a production build, StartReadBuffers() doesn't populate all fields
of a ReadBuffersOperation for a buffer hit because no callers use them
(they are populated in assert builds).

read_buffers() (a test-only function) relied on some of these fields, so
AIO tests failed on non-assert builds (discovered on the buildfarm after
commit 020c02bd908).

Fix by tracking the required information ourselves in read_buffers() and
avoiding reliance on the ReadBuffersOperation unless we know that we did
IO.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/9ce8f5d8-8ab2-4aa2-b062-c5d74161069c%40gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8519251ee975a8cca16fb35d699c1a39f2d217a1

Modified Files
--------------
src/test/modules/test_aio/test_aio.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Jacob Champion
Date:
Subject: pgsql: libpq: Poison the v2 part of a v1 Bearer request
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: warn that parallel pg_restore may fail if --no-schema was u