pgsql: Fix FK triggers losing DEFERRABLE/INITIALLY DEFERRED when marked - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Fix FK triggers losing DEFERRABLE/INITIALLY DEFERRED when marked
Date
Msg-id E1w75LT-0026WK-25@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix FK triggers losing DEFERRABLE/INITIALLY DEFERRED when marked ENFORCED again

Previously, a foreign key defined as DEFERRABLE INITIALLY DEFERRED could
behave as NOT DEFERRABLE after being set to NOT ENFORCED and then back
to ENFORCED.

This happened because recreating the FK triggers on re-enabling the constraint
forgot to restore the tgdeferrable and tginitdeferred fields in pg_trigger.

Fix this bug by properly setting those fields when the foreign key constraint
is marked ENFORCED again and its triggers are recreated, so the original
DEFERRABLE and INITIALLY DEFERRED properties are preserved.

Backpatch to v18, where NOT ENFORCED foreign keys were introduced.

Author: Yasuo Honda <yasuo.honda@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CAKmOUTms2nkxEZDdcrsjq5P3b2L_PR266Hv8kW5pANwmVaRJJQ@mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2497dac55648e738b643577e807bfd2a3ac4c6e2

Modified Files
--------------
src/backend/commands/tablecmds.c          |  2 ++
src/test/regress/expected/foreign_key.out | 53 +++++++++++++++++++++++++++++++
src/test/regress/sql/foreign_key.sql      | 37 +++++++++++++++++++++
3 files changed, 92 insertions(+)


pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: Re: pgsql: Move gramparse.h to src/backend/parser
Next
From: Fujii Masao
Date:
Subject: pgsql: Fix FK triggers losing DEFERRABLE/INITIALLY DEFERRED when marked