pgsql: Add comment explaining fire_triggers=false in ri_PerformCheck() - Mailing list pgsql-committers

From Amit Langote
Subject pgsql: Add comment explaining fire_triggers=false in ri_PerformCheck()
Date
Msg-id E1w71Be-0024fU-0U@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add comment explaining fire_triggers=false in ri_PerformCheck()

The reason for passing fire_triggers=false to SPI_execute_snapshot()
in ri_PerformCheck() was not documented, making it unclear why it was
done that way.  Add a comment explaining that it ensures AFTER triggers
on rows modified by the RI action are queued in the outer query's
after-trigger context and fire only after all RI updates on the same
row are complete.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Surya Poondla <suryapoondla4@gmail.com>
Discussion: https://postgr.es/m/20250331212648.ad4ab804559001d7f0788741@sraoss.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1ad7191f7e927ecda72928a9f1e69d40edfed3e4

Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Make geometry cast functions error safe
Next
From: "Anton A. Melnikov"
Date:
Subject: Re: pgsql: Move gramparse.h to src/backend/parser