pgsql: Remove isolation test lock-stats - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Remove isolation test lock-stats
Date
Msg-id E1w5Bde-001JMo-0F@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove isolation test lock-stats

This test is proving to be unstable in the CI for Windows, at least.
The origin of the issue is that the deadlock_timeout requests may not
be processed, causing the lock stats to not be updated.  This could be
mitigated by making the hardcoded sleep longer, however this would cost
in runtime on fast machines.  On slow machines, there is no guarantee
that an augmented sleep would be enough.

An isolation test may not be the best method to write this test
(TAP test with injection point with a NOTICE+wait_for_log before
processing the deadlock_timeout request should remove the need of a
sleep).  As we are late in the release cycle, I am removing the test for
now to keep the CI and the buildfarm a maximum stable.  Let's revisit
this part later.

Discussion: https://postgr.es/m/hlkdrplgrmudbspibsuq6xooxrqxqsgwo6x5b6x5ptvkgjbe7w@xogt6xgua6dz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7c64d56fd9765bb577937c07eabed971e605c67c

Modified Files
--------------
src/test/isolation/expected/lock-stats.out | 197 -----------------------------
src/test/isolation/isolation_schedule      |   1 -
src/test/isolation/specs/lock-stats.spec   | 128 -------------------
3 files changed, 326 deletions(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Refactor to remove ForeignServerName().
Next
From: John Naylor
Date:
Subject: pgsql: Refactor handling of x86 CPUID instructions