pgsql: Fix copy-paste error in test_ginpostinglist - Mailing list pgsql-committers

From John Naylor
Subject pgsql: Fix copy-paste error in test_ginpostinglist
Date
Msg-id E1w4yws-001Dq0-1u@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix copy-paste error in test_ginpostinglist

The check for a mismatch on the second decoded item pointer
was an exact copy of the first item pointer check, comparing
orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1]
with decoded_itemptrs[1].  The error message also reported (0, 1) as
the expected value instead of (blk, off).  As a result, any decoding
error in the second item pointer (where the varbyte delta encoding
is exercised) would go undetected.

This has been wrong since commit bde7493d1, so backpatch to all
supported versions.

Author: Jianghua Yang <yjhjstz@gmail.com>
Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/791ff1df1ee040cf171100b173f88ffd9ea8a446

Modified Files
--------------
src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Further improve commentary about ChangeVarNodesWalkExpression()
Next
From: Robert Haas
Date:
Subject: pgsql: Prevent spurious "indexes on virtual generated columns are not s