pgsql: Improve commentary about ChangeVarNodesWalkExpression(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve commentary about ChangeVarNodesWalkExpression().
Date
Msg-id E1w4gz6-00162c-39@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve commentary about ChangeVarNodesWalkExpression().

IMO the proximate cause of the bug fixed in commit 07b7a964d
was sloppy thinking about what ChangeVarNodesWalkExpression()
is to be used for.  Flesh out its header comment to try to
improve that situation.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/1607553.1774017006@sss.pgh.pa.us
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a0e0b3cc685aa58d9ff63ed64e45ac1cba297e40

Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix multixact backwards-compatibility with CHECKPOINT race condi
Next
From: Bruce Momjian
Date:
Subject: pgsql: doc: make "datadir" argument specification more specific