pgsql: Ensure "still waiting on lock" message is logged only once per w - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Ensure "still waiting on lock" message is logged only once per w
Date
Msg-id E1w23zQ-0000Pb-32@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Ensure "still waiting on lock" message is logged only once per wait.

When log_lock_waits is enabled, the "still waiting on lock" message is normally
emitted only once while a session continues waiting. However, if the wait is
interrupted, for example by wakeups from client_connection_check_interval,
SIGHUP for configuration reloads, or similar events, the message could be
emitted again each time the wait resumes.

For example, with very small client_connection_check_interval values
(e.g., 100 ms), this behavior could flood the logs with repeated messages,
making them difficult to use.

To prevent this, this commit guards the "still waiting on lock" message so
it is reported at most once during a lock wait, even if the wait is interrupted.
This preserves the intended behavior when no interrupts occur.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Hüseyin Demir <huseyin.d3r@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwHZUmg+r4kMcPYt_Z-txxVX+CJJhfra+qemxKXvAxYbpw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fd6ecbfa75ff0316f17c75d3931f20eb4f6e1231

Modified Files
--------------
src/backend/storage/lmgr/proc.c | 30 ++++++++++++++++++++++++------
1 file changed, 24 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Reject ALTER TABLE .. CLUSTER earlier for partitioned tables
Next
From: Peter Eisentraut
Date:
Subject: pgsql: SQL Property Graph Queries (SQL/PGQ)