pgsql: Tighten asserts on ParallelWorkerNumber - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Tighten asserts on ParallelWorkerNumber
Date
Msg-id E1w1QHj-0008TG-0k@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Tighten asserts on ParallelWorkerNumber

The comment about ParallelWorkerNumbr in parallel.c says:

  In parallel workers, it will be set to a value >= 0 and < the number
  of workers before any user code is invoked; each parallel worker will
  get a different parallel worker number.

However asserts in various places collecting instrumentation allowed
(ParallelWorkerNumber == num_workers). That would be a bug, as the value
is used as index into an array with num_workers entries.

Fixed by adjusting the asserts accordingly. Backpatch to all supported
versions.

Discussion: https://postgr.es/m/5db067a1-2cdf-4afb-a577-a04f30b69167@vondra.me
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0e5ff9b9b45a657aea12440478dc002e9b01f138

Modified Files
--------------
src/backend/executor/nodeAgg.c             | 2 +-
src/backend/executor/nodeBitmapHeapscan.c  | 2 +-
src/backend/executor/nodeBitmapIndexscan.c | 2 +-
src/backend/executor/nodeIncrementalSort.c | 2 +-
src/backend/executor/nodeIndexonlyscan.c   | 2 +-
src/backend/executor/nodeIndexscan.c       | 2 +-
src/backend/executor/nodeMemoize.c         | 2 +-
src/backend/executor/nodeSort.c            | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Tighten asserts on ParallelWorkerNumber
Next
From: Tomas Vondra
Date:
Subject: pgsql: Tighten asserts on ParallelWorkerNumber