pgsql: Allow sibling call optimization in slot_getsomeattrs_int() - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Allow sibling call optimization in slot_getsomeattrs_int()
Date
Msg-id E1w1DF8-0003Uf-2Y@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow sibling call optimization in slot_getsomeattrs_int()

This changes the TupleTableSlotOps contract to make it so the
getsomeattrs() function is in charge of calling
slot_getmissingattrs().

Since this removes all code from slot_getsomeattrs_int() aside from the
getsomeattrs() call itself, we may as well adjust slot_getsomeattrs() so
that it calls getsomeattrs() directly.  We leave slot_getsomeattrs_int()
intact as this is still called from the JIT code.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Discussion: https://postgr.es/m/CAApHDvodSVBj3ypOYbYUCJX%2BNWL%3DVZs63RNBQ_FxB_F%2B6QXF-A%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4deecb52affa4b6f791e8a57f6584610e4dd12f4

Modified Files
--------------
src/backend/executor/execTuples.c | 58 ++++++++++++++++++++-------------------
src/include/executor/tuptable.h   | 13 +++++----
2 files changed, 38 insertions(+), 33 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Use fake LSNs to improve nbtree dropPin behavior.
Next
From: Michael Paquier
Date:
Subject: pgsql: pgstattuple: Optimize pgstattuple_approx() with streaming read