pgsql: doc: Document IF NOT EXISTS option for ALTER FOREIGN TABLE ADD C - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: doc: Document IF NOT EXISTS option for ALTER FOREIGN TABLE ADD C
Date
Msg-id E1vzWsQ-0037iR-1N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
doc: Document IF NOT EXISTS option for ALTER FOREIGN TABLE ADD COLUMN.

Commit 2cd40adb85d added the IF NOT EXISTS option to ALTER TABLE ADD COLUMN.
This also enabled IF NOT EXISTS for ALTER FOREIGN TABLE ADD COLUMN,
but the ALTER FOREIGN TABLE documentation was not updated to mention it.

This commit updates the documentation to describe the IF NOT EXISTS option for
ALTER FOREIGN TABLE ADD COLUMN.

While updating that section, also this commit clarifies that the COLUMN keyword
is optional in ALTER FOREIGN TABLE ADD/DROP COLUMN. Previously, part of
the documentation could be read as if COLUMN were required.

This commit adds regression tests covering these ALTER FOREIGN TABLE syntaxes.

Backpatch to all supported versions.

Suggested-by: Fujii Masao <masao.fujii@gmail.com>
Author: Chao Li <lic@highgo.com>
Reviewed-by: Robert Treat <rob@xzilla.net>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwFk=rrhrwGwPtQxBesbT4DzSZ86Q3ftcwCu3AR5bOiXLw@mail.gmail.com
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/173aa8c5e89130c757c029262f10fc537b6f68ae

Modified Files
--------------
doc/src/sgml/ref/alter_foreign_table.sgml  |  8 +++++---
src/test/regress/expected/foreign_data.out | 13 +++++++++++++
src/test/regress/sql/foreign_data.sql      |  7 +++++++
3 files changed, 25 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix size underestimation of DSA pagemap for odd-sized segments
Next
From: Fujii Masao
Date:
Subject: pgsql: doc: Document IF NOT EXISTS option for ALTER FOREIGN TABLE ADD C